-
Notifications
You must be signed in to change notification settings - Fork 258
fix: fixing the redirection to /docs #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Refactor NotFound component to use window.location.replace for immediate redirect. Signed-off-by: Karan Suresh <karansuresh.info@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Iam-Karan-Suresh changes looks really good, but please fix the prettier and lint issues the pipelines are failing
|
@Achanandhi-M I fixed the prettier issue. Kindly please check |
Achanandhi-M
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Iam-Karan-Suresh i think again the pipelines are failing
Signed-off-by: Karan Suresh <karansuresh.info@gmail.com>
e10797f to
b3cf907
Compare
d30853c to
b3cf907
Compare
Refactor NotFound component to use window.location.replace for immediate redirect. Signed-off-by: Karan Suresh <karansuresh.info@gmail.com>
Signed-off-by: Karan Suresh <karansuresh.info@gmail.com>
Achanandhi-M
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Iam-Karan-Suresh i think again the pipelines are failing, please read the readme of the docs repo on how to fix the prettier and lint issues
6a51545 to
aacad7d
Compare
Signed-off-by: Iam-karan-suresh <karansuresh.info@gmail.com>
aacad7d to
b609834
Compare
|
Hi @Achanandhi-M , thank you for your patience. This is my first contribution to this project, and I apologize for the mistakes in my earlier PR attempts and the confusion around the DCO fixes. I have now corrected everything and verified the commits and PR details. Requesting your review when you have time, and please let me know if any further changes are required. Thank you. |
Title
Refactor NotFound component to use
window.location.replacefor immediate redirectWhat has changed?
This PR updates the NotFound component to use
window.location.replace("/docs")instead of rendering a fallback route.This ensures users are immediately redirected to the
/docspage when accessing a non-existent route, without adding a new entry to the browser history.Why this change?
Using
window.location.replaceprovides a cleaner redirect behavior for documentation routes:Type of change
How has this been tested?
/random) and verified that it immediately redirects to/docs.Checklist
Keploy.Documentation.-.Google.Chrome.2025-11-07.11-17-05.mp4
Additional context
This change improves user experience on broken or outdated links by ensuring seamless redirection to the docs homepage.