Skip to content

feat: implement pagination and search functionality in MoreStories co… #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

MishraShardendu22
Copy link

@MishraShardendu22 MishraShardendu22 commented Feb 22, 2025

Fixes issue : keploy/keploy#2546

Implemented Pagination for Blogs Pages. Points Kept in mind
1.) UI of the site matches the newly added component
2.) The number of pages visible at a time are limited so the bottom of the pages aren't flooded.

image

…mponent

Signed-off-by: Shardendu Mishra <shardendumishrabrave@gmail.com>
@manasmanohar
Copy link
Contributor

Thank you for your implementation!
Your approach works well for controlling what's displayed, but doesn't address the underlying issue. Currently, all posts are still fetched initially, and then just displayed incrementally. A better approach would be, to load data incrementally - fetching only a subset of posts from the API initially, then requesting more as needed upon user clicking load more.

@MishraShardendu22
Copy link
Author

Thank you for your implementation! Your approach works well for controlling what's displayed, but doesn't address the underlying issue. Currently, all posts are still fetched initially, and then just displayed incrementally. A better approach would be, to load data incrementally - fetching only a subset of posts from the API initially, then requesting more as needed upon user clicking load more.

Ok Sir I'll address the issue and fix it by today

@MishraShardendu22
Copy link
Author

I have made the changes in GraphQL queries, I have set the limit to fetch limited queries please review.

@manasmanohar
Copy link
Contributor

hey @MishraShardendu22,

  • While you have updated the query to limit the number of posts fetched at a time, but aren't we still fetching all the post during build time and sending it our client here? as mentioned earlier a better approach would be, to load data incrementally - fetching only a subset of posts from the API initially, then requesting more as needed upon user clicking load more.
  • Load more button is preferred over numbered.
  • Kindly update your pr according to the new pr template.
  • Ensure responsiveness when adding new ui elements (the current numbered pagination ui is not responsive)
    image

@MishraShardendu22
Copy link
Author

Ok sir I'll work on this by today and generate a PR, addressing the issues.

@MishraShardendu22
Copy link
Author

Sir I was not able to do this part "While you have updated the query to limit the number of posts fetched at a time, but aren't we still fetching all the post during build time and sending it our client here? as mentioned earlier a better approach would be, to load data incrementally - fetching only a subset of posts from the API initially, then requesting more as needed upon user clicking load more."

I havent worked with GraphQL queries in such large code base, if you can guide a little that would be really nice, as of now I have fixed the UI things and created a PR.

Copy link

keploy bot commented Apr 15, 2025

Nice Pr 😄. We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

1 similar comment
Copy link

Nice Pr 😄. We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants