-
Notifications
You must be signed in to change notification settings - Fork 52
feat: implement pagination and search functionality in MoreStories co… #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…mponent Signed-off-by: Shardendu Mishra <shardendumishrabrave@gmail.com>
e8553bf
to
d8bd6e2
Compare
Thank you for your implementation! |
Ok Sir I'll address the issue and fix it by today |
Signed-off-by: Shardendu Mishra <shardendumishrabrave@gmail.com>
Signed-off-by: Shardendu Mishra <shardendumishrabrave@gmail.com>
Signed-off-by: Shardendu Mishra <shardendumishrabrave@gmail.com>
…provement Signed-off-by: Shardendu Mishra <shardendumishrabrave@gmail.com>
I have made the changes in GraphQL queries, I have set the limit to fetch limited queries please review. |
hey @MishraShardendu22,
|
Ok sir I'll work on this by today and generate a PR, addressing the issues. |
Sir I was not able to do this part "While you have updated the query to limit the number of posts fetched at a time, but aren't we still fetching all the post during build time and sending it our client here? as mentioned earlier a better approach would be, to load data incrementally - fetching only a subset of posts from the API initially, then requesting more as needed upon user clicking load more." I havent worked with GraphQL queries in such large code base, if you can guide a little that would be really nice, as of now I have fixed the UI things and created a PR. |
Nice Pr 😄. We currently support Unit Test Generation only for Go projects. |
1 similar comment
Nice Pr 😄. We currently support Unit Test Generation only for Go projects. |
Fixes issue : keploy/keploy#2546
Implemented Pagination for Blogs Pages. Points Kept in mind
1.) UI of the site matches the newly added component
2.) The number of pages visible at a time are limited so the bottom of the pages aren't flooded.