Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Lua 5.2 #2

Merged
merged 9 commits into from
Aug 31, 2015
Merged

Support for Lua 5.2 #2

merged 9 commits into from
Aug 31, 2015

Conversation

tst2005
Copy link
Member

@tst2005 tst2005 commented Aug 7, 2015

No description provided.

hishamhm
hishamhm reviewed Aug 7, 2015
View reviewed changes
src/grammar.lua
@@ -204,7 +204,10 @@ local lpeg = require 'lpeg'
local P, V = lpeg.P, lpeg.V

-- module declaration
module 'leg.grammar'
--module 'leg.grammar'
local _M = {} -- the leg.grammar module
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please declare a table with the name of the module (grammar)

@hishamhm
Copy link
Member

hishamhm commented Aug 7, 2015

Hi, thanks for the pull request! I reviewed it and made remarks above. Please make the changes and all merge the PR.

Note that this project is currently unmaintained. I added you as a committer, so you can take over project maintenance if you want, and commit any further additions directly. Thanks!

@tst2005
Copy link
Member Author

tst2005 commented Aug 9, 2015

There are some missing stuff in my fix. See my last commit : 5938917

Now require "peg".grammar equal to require "peg.grammar"

tst2005 added 8 commits August 14, 2015 20:40
@tst2005
fix to unix end of line
c349605
@tst2005
fix end of line
31a7ab9
@tst2005
remove all trailing spaces
48465bc
@tst2005
typo fix
4bea389 
The test have a '\o'.
In Lua 5.1 '\o' becomes 'o', but Lua 5.2 '\o' is not allowed and raise an error.
I supposed it was a typo.
@tst2005
remove use of module()
a66dacd
@tst2005
no more global, fixed
e0e8b21
@tst2005
missing part
078d219
@tst2005
save
e91ecfa
hishamhm added a commit that referenced this pull request Aug 31, 2015
@hishamhm
Merge pull request #2 from tst2005/fix-for-lua5.2
dcd25ff 
Support for Lua 5.2
@hishamhm hishamhm merged commit dcd25ff into keplerproject:master Aug 31, 2015
@hishamhm
Copy link
Member

Thank you for the PR updates! It is now merged!

@tst2005 tst2005 deleted the fix-for-lua5.2 branch September 1, 2015 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tst2005 @hishamhm