[Enhancement] add font weight option for Text Labels #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-polic
commented
Oct 7, 2024
alex-polic
commented
- work based on issue [Question] Label Font Bold #1468
- add font weight in list of settings for Text Labels
- integrate with localization
- hook with deck.gl fontWeight options for TextLabel
- Currently, there is an option through deck.gl to change Font Family and Font Weight per layer, this PR only works with Font Weight
- The default font used for Text Labels in deck.gl is Monaco monospaced. This font does not provide full variety of weight options (only 2), which creates a problem visually (text doesn't seem bolded when weight is increased)
- It would be beneficial to either change the default font or allow users to use multiple fonts. Design and business input required before making adjustments
* add font weight in list of settings for Text Labels * integrate with localization * hook with deck.gl fontWeight options for TextLabel
❌ Deploy Preview for keplergl2 failed. Why did it fail? →
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.