Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Add neighbor column mode to arc layer, support arc from hex #2665

Merged
merged 2 commits into from
Sep 24, 2024
Merged

[Feat] Add neighbor column mode to arc layer, support arc from hex #2665

merged 2 commits into from
Sep 24, 2024

Conversation

igorDykhta
Copy link
Collaborator

  • Cleanup columnMode logic, remove use of assignColumnsByColumnMode
  • Add neighbor column mode to arc layer
  • Support arc from hex_id
  • [fix] Ensure Polygon layer filtering in table columns mode works
  • [fix] Timestamp in the Trips layer is not required after switching from Polygon

@igorDykhta igorDykhta force-pushed the igr/ups/geojson-path-from-point branch from b8b26a8 to d9df091 Compare September 24, 2024 11:02
Base automatically changed from igr/ups/geojson-path-from-point to master September 24, 2024 11:38
igorDykhta and others added 2 commits September 24, 2024 14:50
@igorDykhta
[Feat] Add neighbor column mode to arc layer, support arc from hex
b21d2f6 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@igorDykhta
fix lint
74f9ffd 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@netlify Netlify
Copy link

netlify bot commented Sep 24, 2024 •
edited
Loading

❌ Deploy Preview for keplergl2 failed. Why did it fail? →

Name Link
🔨 Latest commit 74f9ffd
🔍 Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/66f2a94b91dfa20008bd6685

@igorDykhta igorDykhta merged commit b6ac654 into master Sep 24, 2024
4 of 12 checks passed
@igorDykhta igorDykhta deleted the igr/ups/arc-neighbour-and-hex branch September 24, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyabo ilyabo ilyabo approved these changes

@heshan0131 heshan0131 Awaiting requested review from heshan0131

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorDykhta @ilyabo