Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Split out column mode config into separate component #2663

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[chore] Split out column mode config into separate component #2663

merged 1 commit into from
Sep 24, 2024

Conversation

igorDykhta
Copy link
Collaborator

  • This PR splits out a more general-purpose ColumnModeConfig that we can use separately outside of the layer panel.
  • Looks the same as before, changes here should not affect user experience:

@igorDykhta
[chore] Split out column mode config into separate component
b4cec94 
Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com>
@netlify Netlify
Copy link

netlify bot commented Sep 23, 2024 •
edited
Loading

❌ Deploy Preview for keplergl2 failed. Why did it fail? →

Name Link
🔨 Latest commit b4cec94
🔍 Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/66f1eb9aceb9370008fe91f4

@igorDykhta igorDykhta merged commit 4c48994 into master Sep 24, 2024
4 of 12 checks passed
@igorDykhta igorDykhta deleted the igr/ups/column-mode-config-sep-comp branch September 24, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyabo ilyabo ilyabo approved these changes

@heshan0131 heshan0131 Awaiting requested review from heshan0131

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorDykhta @ilyabo