Repository navigation
Images: pick the largest srcset candidate and keep caption formatting - #409
Open
lagudafuadtosin wants to merge 1 commit into
Open
lagudafuadtosin wants to merge 1 commit into
lagudafuadtosin wants to merge 1 commit into
Conversation
…n captions Two fixes in the <picture>/<figure> standardization path: - <picture> set img src to the first srcset candidate, which is usually the smallest. Markdown keeps a single src, so pick the largest width/density candidate instead (kepano#406). - figcaption content was flattened to plain text, dropping links and footnote references. Preserve the caption's inline HTML (kepano#369). Adds a test covering both, failing before and passing after.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes in
src/elements/images.ts.#406:
<picture>setimg srcto the first (smallest) srcset candidate.It now picks the largest, full srcset kept.
#369: figcaption flattened to plain text, dropping links and footnote refs.
Sorted, keeps the caption's inline HTML.
Test covers both, fails before and passes after.