Repository navigation
Conversation
.fulltext-view is now matched in the same ENTRY_POINT_ELEMENTS slot as [role="article"], below article and above main. Sharing that slot avoids a new entry, which would raise every earlier selector by 40 points over main. removeHiddenElements skips any element inside .fulltext-view and keeps its descendants, including sections that are themselves display:none. The HighWire fixture expects the introduction and results from that hidden view, and the nested-teaser fixture keeps the surrounding article paragraphs along with the inner preview. Fixes kepano#257
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.fulltext-view is now matched in the same ENTRY_POINT_ELEMENTS slot as [role="article"], below article and above main. Sharing that slot avoids a new entry, which would raise every earlier selector by 40 points over main. removeHiddenElements skips any element inside .fulltext-view and keeps its descendants, including sections that are themselves display:none. The HighWire fixture expects the introduction and results from that hidden view, and the nested-teaser fixture keeps the surrounding article paragraphs along with the inner preview.
Test plan
npm testlocally; it passed.Why
On bioRxiv and other HighWire pages such as medRxiv, reader extraction and clipping return the short abstract and omit the rest of the paper. The full text is in the page, but the captured result is only the summary card. HighWire keeps the inactive full-text view, and each section inside it, at display:none until that view is selected. removeHiddenElements deletes elements whose inline style matches those hidden patterns, so the .fulltext-view subtree is removed, and .fulltext-view was not an entry point, so the visible abstract article remained the content root.
Fixes #257