Repository navigation
Conversation
XIAX66
marked this pull request as ready for review
October 3, 2026 14:24
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The book page reported in #386 extracts the search panel's 73 words while dropping all five book and annotation paragraphs. The adjacent page has the same failure. Both pages keep their book text in a unique
.nasscontainer; the search panel reuses the generic#contententry point.Add a Shamela extractor that selects the known text container through the existing
contentSelectorpipeline. It applies only toshamela.wsorwww.shamela.ws, numeric/book/<book>/<page>paths, and a unique nonempty.nassroot. Missing, empty, or ambiguous roots retain automatic extraction. An explicit callercontentSelectoropts out of the new extractor. Generic hidden-content recovery is unchanged, including articles rendered inside hidden overlays/dialogs.Related to #386. This targets the verified book-page structure; it does not establish support for every Shamela layout or change cross-site dialog heuristics.
Validation on Node 24 / macOS:
npm testandnpm run test:jsdom: 800 tests pass in each.npm run build,npm run lint:innerhtml,npm run lint:unused,npm run size, andgit diff --checkpass.Cloudflare Worker, happy-dom, and Node 20/22 were not directly exercised locally. Remote CI has not yet been verified.
Prepared with AI assistance; the reproduction and validation above were run locally.