Repository navigation
Conversation
When an <img> element has a srcset attribute with width descriptors, select the largest-width variant instead of the small fallback URL in src. Sites like Substack serve article images via CDN with multiple resolutions in srcset (e.g. 424w, 848w, 1272w, 1456w) but set src to the smallest variant. This caused Obsidian Web Clipper to embed thumbnail-sized images even when full-width originals were available. The parser tokenizes by whitespace rather than splitting on commas to handle CDN image URLs that embed comma-separated transform parameters directly in the URL path (e.g. Substack's w_424,c_limit,f_webp pattern). Falls back to src when srcset is absent or contains no width descriptors (density-only srcsets like 1x/2x are not used for selection). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
Closed via c5adda3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an![]()
element has a srcset attribute with width descriptors, select the largest-width variant instead of the small fallback URL in src.
Sites like Substack serve article images via CDN with multiple resolutions in srcset (e.g. 424w, 848w, 1272w, 1456w) but set src to the smallest variant. This caused Obsidian Web Clipper to embed thumbnail-sized images even when full-width originals were available.
The parser tokenizes by whitespace rather than splitting on commas to handle CDN image URLs that embed comma-separated transform parameters directly in the URL path (e.g. Substack's w_424,c_limit,f_webp pattern).
Falls back to src when srcset is absent or contains no width descriptors (density-only srcsets like 1x/2x are not used for selection).