Skip to content

Doc fr #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 19, 2018
Merged

Doc fr #394

merged 6 commits into from
Aug 19, 2018

Conversation

redoules
Copy link
Contributor

@redoules redoules commented Aug 18, 2018

(Put an X inside the [ ] to denote check mark [X].)

  • If creating a new file :

    • added links to it in the README files ?
    • included tests with it ?
    • added description (overview of algorithm, time and space compleixty, and possible edge case) in docstrings ?
  • if done some changes :

    • wrote short description in the PR explaining what the changes do ?
    • Fixes #[issue number] if related to any issue
  • other

Added a french translation for the readme, the contributing and modified the other readme in order to add the link to the french doc
added a french translation for the code of conduct
added a link to the french translation of the readme
added the link to the french doc in the readme
the french contributing page now links to the french version of the code of conduct
@redoules
Copy link
Contributor Author

Hello,
I wrote a french translation of the repo. Hope it helps.

@redoules redoules closed this Aug 18, 2018
@redoules redoules reopened this Aug 18, 2018
@coveralls
Copy link

coveralls commented Aug 18, 2018

Pull Request Test Coverage Report for Build 728

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.509%

Totals Coverage Status
Change from base Build 726: 0.0%
Covered Lines: 4307
Relevant Lines: 6023

💛 - Coveralls

@danghai
Copy link
Collaborator

danghai commented Aug 19, 2018

@redoules Thanks your PR. I could not confirm the translation because I do not know French language. However it looks good for me. Feel free open new PR if people want to modify the translation. Merge!

@danghai danghai merged commit e6df887 into keon:master Aug 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants