strip_url_params.py : BUG in function strip_url_params3(...)

[christianbender]

The file strip_url_params.py is buggy. Because one times the tests run successful and a other times it fails. I comment out the test for this file.

important: The bug is in the function strip_url_params3 of the file above.

@SaadBenn Can you look in it? The project is from you.

[SaadBenn]

Yeah sure, currently I'm a bit busy. Is it okay if I take my time with it? I have some huge assignments atm that I need to complete and that's the reason I have not been so active lately. @christianbender

[danghai]

Could you elaborate the error you got?

[christianbender]

@danghai The error message of the failed test looks so

line 330, in test_strip_url_params3
self.assertEqual(strip_url_params3("www.saadbenn.com?a=1&b=2&a=2"), "www.saadbenn.com?a=1&b=2")
AssertionError: 'www.saadbenn.com?b=2&a=1' != 'www.saadbenn.com?a=1&b=2'

• www.saadbenn.com?b=2&a=1
  ? ----

• www.saadbenn.com?a=1&b=2
  ? ++++

Sometime the tests run successful but sometimes the test fails.

@SaadBenn You can take your time. Because I comment out the tests.

[SaadBenn]

I'll step through it today once I get off work. @christianbender

[christianbender]

@SaadBenn Thanks

[programatt]

@christianbender @SaadBenn I took a shot at it. I think it just needs to use an OrderedDict instead of a defaultdict so that the looping of the keys is deterministic. See PR #367

[programatt]

@danghai Uh oh, looks like it didn't fix it. The build failed.