Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Generated comment to all generated files #18

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Add Generated comment to all generated files #18

merged 1 commit into from
Mar 29, 2022

Conversation

ingwarsw
Copy link
Contributor

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2057348199

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.548%
Totals Coverage Status
Change from base Build 2034707973: 0.0%
Covered Lines: 137
Relevant Lines: 168
💛 - Coveralls

@ingwarsw ingwarsw requested a review from a team March 29, 2022 08:30
theclapp
theclapp approved these changes Mar 29, 2022
View reviewed changes
Copy link

@theclapp theclapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This repo looks like a great candidate for Go v1.18 generics.

@ingwarsw
Copy link
Contributor Author

True... But thats other story..

@ingwarsw ingwarsw merged commit 9f5f29f into main Mar 29, 2022
@ingwarsw ingwarsw deleted the ing-generated branch March 29, 2022 14:56
@wblakecaldwell
Copy link
Contributor

LGTM.

This repo looks like a great candidate for Go v1.18 generics.

Yeah, and even at the time, it was a good candidate for go generate, but I hadn't gotten around to figuring that out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theclapp theclapp theclapp approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "// code generated by.... DO NOT EDIT" in generated files
4 participants
@ingwarsw @coveralls @wblakecaldwell @theclapp