Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package-lock.json #15

Closed
wants to merge 1 commit into from

Conversation

wilsonparson
Copy link

The existing package-lock.json is causing npm installs to fail.
This change includes a freshly generated package-lock.json by removing it and running npm install.

Loving the course so far 👏

The existing package-lock.json was causing npm installs to fail.
This change includes a freshly generated package-lock.json by
removing it and running npm install.
@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   86.23%   86.23%           
=======================================
  Files          23       23           
  Lines         218      218           
  Branches       12       12           
=======================================
  Hits          188      188           
  Misses         29       29           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cabf29...3d8b395. Read the comment docs.

@kentcdodds
Copy link
Owner

Hi @wilsonparson,

Thank you for letting me know about this. I hope you don't mind, but I'm going to update it myself. It's just that a package-lock.json is very hard to review and is therefore a great attack-vector for bad actors wanting to cause trouble. I don't think you fall into that category, but it's better to be safe than sorry. I hope you understand.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants