Repository navigation
Remove inline MIME runtime compatibility - #854
Merged
Merged
Conversation
📝 WalkthroughWalkthroughEmail raw-MIME handling now stores and reads content through deterministic R2 keys, updates deletion and retention cleanup to delete those keys before D1 rows, excludes transitional cleanup-queue data from runtime account coverage, and removes the offload maintenance endpoint and deployment sweep. ChangesRaw-MIME storage contract
Deletion and retention cleanup
Offload maintenance removal
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant InboundEmail
participant insertEmailMessage
participant EMAIL_BLOBS
participant APP_DB
participant loadRawMime
InboundEmail->>insertEmailMessage: parse and store raw MIME
insertEmailMessage->>EMAIL_BLOBS: write deterministic object
insertEmailMessage->>APP_DB: store raw_mime_key
loadRawMime->>EMAIL_BLOBS: read by raw_mime_key
EMAIL_BLOBS-->>loadRawMime: return raw MIME
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cursor
Bot
force-pushed
the
cursor/legacy-purge-b-data-migrations-f449
branch
from
July 22, 2026 08:07
b75dcac to
0eb3a8b
Compare
kody-bot
marked this pull request as ready for review
July 22, 2026 08:09
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/deploy.yml (1)
269-269: 🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy liftGate deployment on the required raw-MIME transition verification.
The PR requires production confirmation that
remainingInline=0,remainingBlockedInline=0, andremainingBlobCleanup=0, but this workflow removes the maintenance step without adding any equivalent pre-deploy check. Deploying first can leave legacy MIME unreadable and cleanup-queue rows outside deletion/export coverage. Add a pre-deploy D1 verification gate or an auditable required release step before this removal ships.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/deploy.yml at line 269, Update the production deployment workflow around “🧪 Execute smoke check (production)” to add an auditable pre-deploy D1 verification gate before deployment proceeds. The gate must confirm remainingInline=0, remainingBlockedInline=0, and remainingBlobCleanup=0, and fail or block the deployment when any value is nonzero; preserve the existing smoke-check flow after successful verification.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/deploy.yml:
- Line 269: Update the production deployment workflow around “🧪 Execute smoke
check (production)” to add an auditable pre-deploy D1 verification gate before
deployment proceeds. The gate must confirm remainingInline=0,
remainingBlockedInline=0, and remainingBlobCleanup=0, and fail or block the
deployment when any value is nonzero; preserve the existing smoke-check flow
after successful verification.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: b22cc030-d27a-454b-99ed-0a401ba932bc
📒 Files selected for processing (26)
.github/workflows/deploy.ymldocs/contributing/architecture/data-storage.mdpackages/worker/src/app/account-data-targets.tspackages/worker/src/app/account-deletion.node.test.tspackages/worker/src/app/account-deletion.tspackages/worker/src/app/account-export.node.test.tspackages/worker/src/app/admin-system-email-data.tspackages/worker/src/app/retention.node.test.tspackages/worker/src/app/retention.tspackages/worker/src/email-raw-mime-offload-maintenance.node.test.tspackages/worker/src/email-raw-mime-offload-maintenance.tspackages/worker/src/email-raw-mime-offload-races.node.test.tspackages/worker/src/email/inbound.tspackages/worker/src/email/inbound.workers.test.tspackages/worker/src/email/outbound.workers.test.tspackages/worker/src/email/parser.tspackages/worker/src/email/raw-mime-key.node.test.tspackages/worker/src/email/repo.tspackages/worker/src/email/system-email.tspackages/worker/src/email/test-schema.tspackages/worker/src/email/types.tspackages/worker/src/index.tspackages/worker/src/mcp/capabilities/admin/admin-capabilities.node.test.tspackages/worker/src/security/public-route-hardening.workers.test.tspackages/worker/src/storage-runner.workers.test.tspackages/worker/src/test-support/email-raw-mime-offload-fixtures.ts
💤 Files with no reviewable changes (9)
- packages/worker/src/email-raw-mime-offload-maintenance.node.test.ts
- packages/worker/src/email-raw-mime-offload-races.node.test.ts
- packages/worker/src/index.ts
- packages/worker/src/email/types.ts
- packages/worker/src/email-raw-mime-offload-maintenance.ts
- packages/worker/src/app/admin-system-email-data.ts
- packages/worker/src/security/public-route-hardening.workers.test.ts
- packages/worker/src/test-support/email-raw-mime-offload-fixtures.ts
- packages/worker/src/app/account-data-targets.ts
Contributor
|
🔎 Preview deployed: https://kody-pr-854.kody-a99.workers.dev Worker: Mocks:
|
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
raw_mime_keyonlyRollout
Production after required-R2 writes reported
remainingInline=0,remainingBlockedInline=0, andremainingBlobCleanup=0. This is the code-first half of expand/contract; no schema migration is included.Validation
System recap — extends existing primitives (medium risk)
Mode: recap · Base:
main@a25adea9· Head:b75dcac5Classification: extends — removes runtime dependence on transitional MIME schema while retaining physical compatibility for one release.
Invariants
Summary by CodeRabbit
New Features
Bug Fixes
Chores