Repository navigation
docs: close out legacy migration narratives - #1218
Conversation
📝 WalkthroughWalkthroughThe pull request removes a historical audit and updates architecture documentation and code comments to describe finalized storage authorities, Mailbox behavior, UserMeter ownership, and permanent package import and invocation restrictions. Runtime behavior and public declarations remain unchanged. ChangesPost-migration state alignment
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🔎 Preview deployed: https://kody-pr-1218.kody-a99.workers.dev Worker: Mocks:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/contributing/package-codemods.md`:
- Around line 167-169: Qualify the lockstep statement in
docs/contributing/package-codemods.md:167-169 to apply only to parsed findings,
unless publish lint is also updated to include parse-failure findings. Update
the collector documentation in
packages/worker/src/package-runtime/deprecated-invocation-usage.ts:7-11 to state
that parsed findings remain aligned while unparseable files produce codemod-only
manual findings.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f3ff287c-b6a2-4511-a3a1-48959635dc93
📒 Files selected for processing (24)
docs/contributing/architecture/capability-and-primitive-audit-2026-07.mddocs/contributing/architecture/data-storage.mddocs/contributing/architecture/entitlements.mddocs/contributing/architecture/feature-flags.mddocs/contributing/architecture/primitives.yamldocs/contributing/package-codemods.mddocs/contributing/packages-and-manifests.mddocs/use/packages.mdpackages/worker/src/app/account-usage-data.node.test.tspackages/worker/src/entitlements/d1-storage-reconciliation.tspackages/worker/src/entitlements/service.tspackages/worker/src/entitlements/user-meter-do.tspackages/worker/src/mcp/fetch-gateway.node.test.tspackages/worker/src/mcp/runtime-helper-manifest.tspackages/worker/src/package-codemods/codemods/0001-ambient-storage-to-package-storage.tspackages/worker/src/package-codemods/codemods/0002-static-first-invocation.tspackages/worker/src/package-invocations/idempotent-module-invocation.tspackages/worker/src/package-runtime/deprecated-invocation-usage.tspackages/worker/src/package-runtime/module-graph-import-rewriting.tspackages/worker/src/package-runtime/package-app.tspackages/worker/src/package-runtime/runtime-source-modules.tspackages/worker/src/repo/checks.tspackages/worker/src/usage/aggregate-rollups.tstools/check-docs-temporal-language.ts
💤 Files with no reviewable changes (2)
- docs/contributing/architecture/capability-and-primitive-audit-2026-07.md
- tools/check-docs-temporal-language.ts
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
65fbb7a to
db4a0e7
Compare
Intent
Finish the documentation/comment closeout for the pre-launch legacy elimination program tracked in #1069. Current-operations docs should describe only the final storage and package-authoring contracts.
Summary
Testing
npm run validate— passed on the post-Remove legacy jobs and RunLog observability residue #1215 rebased head (553 test files / 1,855 tests; 7 Playwright E2E tests; docs temporal-language check passed)System changes
System recap — composes existing primitives (low risk)
Mode: recap · Base:
main@984b2fcc· Head:db4a0e71Classification: composes — documentation, comments, and teaching copy are aligned with existing runtime contracts; no primitive behavior or schema changes.
Primitives touched
user-meterpackage-runtimepackage-codemodsmcp-serverrepo-sessionsentitlementsSystem map
Package source is checked at publish time and repaired through codemods; runtime teaching errors reinforce the same contract. UserMeter documentation reflects the existing split between authoritative DO state and D1 inventory.
Legend: green = composes (wiring only) · amber = extended by this PR · red = new primitive · gray = context (unchanged, included only when an edge crosses it).
Invariants
Conductor report
STATUS done — PR #1218 squash-merged as
116bfd3b; post-#1215 rebase and final-schema review complete; localnpm run validate, PR CI, main validation, and production deploy are green. Remaining work: only the separately deferred migration-history squash.Summary by CodeRabbit