Repository navigation
Fix: Preact build doesn't work due to incorrect Preact imports - #235
Merged
Merged
Conversation
kentcdodds
approved these changes
Jul 8, 2023
kentcdodds
left a comment
kentcdodds
left a comment
Owner
There was a problem hiding this comment.
This is a backing change, bit I believe downshift is the only active library using this feature so I have no problem merging.
Owner
|
Thank you for working on this. Hopefully CI works because this project isn't very active and some things could be outdated. |
Codecov Report
@@ Coverage Diff @@
## main #235 +/- ##
==========================================
+ Coverage 63.33% 63.39% +0.06%
==========================================
Files 21 21
Lines 600 601 +1
Branches 227 227
==========================================
+ Hits 380 381 +1
Misses 179 179
Partials 41 41
|
Owner
|
@all-contributors please add @SaiMaheshwarReddy for code |
Contributor
|
I've put up a pull request to add @SaiMaheshwarReddy! 🎉 |
|
🎉 This PR is included in version 14.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Preact build doesn't work due to incorrect Preact imports
Why: downshift is not working with preact
How: I had to go through the build process and change import alias from "preact" to "preact/compat"
Checklist:
Steps I followed to test:
Downshift issues related to this: