Optimization: intern every field on the 'rule' hash. #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a rather speculative optimization that converts rewrite_rule.rb to using symbols instead of strings for it's fields. It should definitely make using the rules some faint little bit faster. There is some cost to interning the rules, but this is only paid once, at initialization time.
Contributor
|
Currently, I vote 👎 for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a speculative optimization that converts
rewrite_rule.rbto using symbols instead of strings for therulehash's keys . It should make processing the rules some faint little bit faster.There is some cost to interning the rules, but this is only paid once, at initialization time.
For more information, see also http://stackoverflow.com/questions/8189416/why-use-symbols-as-hash-keys-in-ruby .