Skip to content

Add customItemsRenderer prop #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 26, 2021
Merged

Add customItemsRenderer prop #152

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6d801c
Add customItemsRenderer prop
yegor-babiy Jan 25, 2021
20a593f
del spread props from customItemsRenderer
yegor-babiy Jan 25, 2021
7caf8be
add new customItemsRenderer prop to readme.md
yegor-babiy Jan 25, 2021
85c30ca
add selectedItem, forwardIconRenderer to props
yegor-babiy Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 24 additions & 14 deletions packages/core/src/tree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ const Tree = props => {
itemsRenderer: Items = ItemsRenderer,
forwardIconRenderer,
treeContainerRenderer: TreeContainer = TreeContainerRenderer,
customItemsRenderer,
selectedItem
} = props;

Expand Down Expand Up @@ -94,20 +95,29 @@ const Tree = props => {
inputIconRenderer={inputIconRenderer}
clearIconRenderer={clearIconRenderer}
/>
<Items styles={styles} getStyles={getStyles} height={itemsHeight}>
{leaves &&
leaves.length > 0 &&
leaves.map(item => (
<Item
getStyles={getStyles}
searchTerm={searchTerm}
item={item}
onClick={onClick}
forwardIconRenderer={forwardIconRenderer}
selectedItem={selectedItem}
/>
))}
</Items>
{customItemsRenderer ? (
React.cloneElement(customItemsRenderer, {
...props,
Copy link
Contributor

@liorheber liorheber Jan 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should just pass the props (I'm talking about ...props), the props are meant for tree.
As any custom renderer, you can OTHER props externally when you do something like

<Tree customItemsRenderer=<MyRenderer someProp={} />

Unless you mean yo pass something like

<Tree customItemsRenderer={someRenderer}/>

In which case you also need to create the component in the tree and you can still pass props using something like

<Tree customItemsRenderer={() => <SomeRenderer .../>}/>

Hope my comment is understandable.

leaves,
searchTerm,
onClick
})
) : (
<Items styles={styles} getStyles={getStyles} height={itemsHeight}>
{leaves &&
leaves.length > 0 &&
leaves.map(item => (
<Item
getStyles={getStyles}
searchTerm={searchTerm}
item={item}
onClick={onClick}
forwardIconRenderer={forwardIconRenderer}
selectedItem={selectedItem}
Comment on lines +116 to +117
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't want to pass these two?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as I see selected Item we pass externally

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ForwardIconRenderer the same

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's important we maintain the same API.
IT would be very confusing if the icons work in one instance but if you pass a custom list they don't.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a ping on this so that we can merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

/>
))}
</Items>
)}
{leaves && leaves.length === 0 && (
<NoResults
height={itemsHeight}
Expand Down