Support Material-UI tree #143
Conversation
| "author": "ui@kenshoo.com", | ||
| "license": "MIT", | ||
| "peerDependencies": { | ||
| "@kenshooui/react-tree": "^1.0.0", |
There was a problem hiding this comment.
I would add this to dev as well.
There was a problem hiding this comment.
@liorheber please publish react-tree
|
Something with the left arrow doesn't seem aligned properly: |
|
Something in the search isn't working properly, after each character it blurs out of the input and I need to click on the input again to continue typing. |
It's a regression caused by "React.forwardRef..." |
It's seems like this because of the "hover circle": @liorheber I can remove this behavior and add some custom behavior on hover (or just live it without hover behavior) |
| containerRef?.current?.clientHeight - | ||
| headerRef?.current?.clientHeight - | ||
| inputRef?.current?.clientHeight; |
There was a problem hiding this comment.
Will this work properly for stuff that is missing? say 300 - undefined - 10?
There was a problem hiding this comment.
@liorheber I don't think so.
What is the desirable behavior n this case? give itemsHeight a default value?
There was a problem hiding this comment.
If it doesn't exist I'd expect it to have a clientHeight value of 0 -
Why? If the ref doesn't exist it means that it was not inserted. if it was not inserted it should take 0px of the height.
Does that make sense?
There was a problem hiding this comment.
Same about containerRef? because in this case we will get negative result
|
|
||
| const Tree = props => { | ||
| const { | ||
| structure = [], | ||
| title, | ||
| onSelect, | ||
| className, |
There was a problem hiding this comment.
@liorheber Here is the removal of className.
Is it ok? Or should I change it back?
No description provided.