Skip to content

Feature : MultiSelect can be used as a controlled component (#156)#160

Merged
liorheber merged 1 commit intokenshoo:masterfrom
baptwaels:multi-select-controlled-component
Jul 23, 2019
Merged

Feature : MultiSelect can be used as a controlled component (#156)#160
liorheber merged 1 commit intokenshoo:masterfrom
baptwaels:multi-select-controlled-component

Conversation

@baptwaels
Copy link
Contributor

Proposed Changes

  • Able to use the component as a controlled components

@baptwaels baptwaels force-pushed the multi-select-controlled-component branch 3 times, most recently from cc83cce to 488487d Compare July 12, 2019 07:54
@yegor-babiy
Copy link
Contributor

yegor-babiy commented Jul 12, 2019

@baptwaels thanks for your effort,
I am also investigated such issue and found the same solution, like you.
@liorheber, checked all available component states, it works as expected
I think it's good candidate for merging.

@baptwaels
Copy link
Contributor Author

@yegor-babiy Alright, thanks. What should I do next ?

@yegor-babiy
Copy link
Contributor

@yegor-babiy Alright, thanks. What should I do next ?

waiting on @liorheber approval

@liorheber
Copy link
Collaborator

Thank you @baptwaels !

@liorheber liorheber merged commit 01e6017 into kenshoo:master Jul 23, 2019
@baptwaels
Copy link
Contributor Author

Great ! Thanks for the review @yegor-babiy @liorheber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants