-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin graphql core <3.1 #793
Pin graphql core <3.1 #793
Conversation
Should also update setup.py. Sad to see the semver https://semver.org/ principles broken. But probably this is on us since we rely on their internals |
3.1 is the Python equivalent of the Javascript v15 library. The Javascript library seems to be following semver. I'm not sure what we were using is internal, so it may or may not be on us. We should maybe bring this up with the GraphQL-core maintainers, just to understand what our expectations should be around version bumps. In the meantime, I suggest we pin to minor versions instead of majors. |
@bojanserafimov can you take a look at the |
The |
Sure. I'll send a diff for that file soon. |
Codecov Report
@@ Coverage Diff @@
## master #793 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 106 106
Lines 8241 8243 +2
=======================================
+ Hits 7814 7816 +2
Misses 427 427
Continue to review full report at Codecov.
|
3.1 contains a breaking change.