Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): cell links to problem in TrainingContestTable #666

Merged
merged 1 commit into from
Jul 5, 2020

Conversation

southball
Copy link
Contributor

Fixes #663.

#663 の機能を実装しました。

ちなみに NewTabLinkhrefstring から string | undefined を変えましたが、JSX の a.hrefstring | undefined からです。これは大丈夫ですか、それとも別の書き方のほうがいいんですか。(undefined の他に # または javascript:void(0) も使えるんですが…)

@kenkoooo
Copy link
Owner

kenkoooo commented Jul 5, 2020

hrefundefined だとリンクってどうなるんですか?

@southball
Copy link
Contributor Author

southball commented Jul 5, 2020

image

image

href がなくなります。押しても新しいタブを作りません。
(テキストになると言えますね)

@kenkoooo
Copy link
Owner

kenkoooo commented Jul 5, 2020

なるほど、でしたら大丈夫そうです。

@kenkoooo kenkoooo merged commit 3634ee7 into kenkoooo:master Jul 5, 2020
@southball southball deleted the feat-shugyou branch July 12, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

バチャの Training モードで、問題リンクをクリックするのが難しい
2 participants