Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in bower.json, there was a missing semicolon #85

Closed
wants to merge 1 commit into from
Closed

Fixed typo in bower.json, there was a missing semicolon #85

wants to merge 1 commit into from

Conversation

jett-dave
Copy link

It looks like bower.json was missing a semicolon, causing bower install to fail.

@sjoness
Copy link
Contributor

sjoness commented Sep 4, 2013

Oh well spotted @dlachapelle! Sorry about this @kenkeiter, my fault.

@kenkeiter
Copy link
Owner

@sjoness No worries! Actually, would you be willing to submit a patch for this on the develop branch (when you have a second), with an updated list of dependencies? I'm happy to include bower if it makes people's lives easier, but I'd prefer not to have to 100% understand it myself, since I don't use it ;)

I can't accept this PR, since it's on the master branch. PRs are only accepted on the develop branch :) Either way, great catch, and thank you :)

@sjoness
Copy link
Contributor

sjoness commented Sep 4, 2013

@kenkeiter Sure I can do that. Is this project at version 1.0.0 now? I haven't been keeping up.

kenkeiter added a commit that referenced this pull request Sep 4, 2013
@kenkeiter kenkeiter closed this Sep 4, 2013
@kenkeiter
Copy link
Owner

@sjoness Changes are now in master -- I released them as a hotfix. If you can go ahead and $ bower register skeuocard I'd be much obliged ;)

@sjoness
Copy link
Contributor

sjoness commented Sep 4, 2013

@kenkeiter there seems to be a problem with Bower 1.2.6. Trying to figure out a fix at the moment.

Edit: I think I have gotten to the root of the problem. You need to apply the recent changes of bower.json to the 1.0.2 release.

$ git tag 1.0.2
$ git push origin 1.0.2

@jett-dave
Copy link
Author

My bad - sorry, should've looked for a develop branch before submitting a pull request to master.

@kenkeiter
Copy link
Owner

@dlachapelle No worries, man! All contributions are appreciated, regardless of what branch they're on ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants