Fix iOS17 bug where encoding buffer does not include newline character #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…character is not stringified
|
Hey sorry, can you add in to the DOCS that this change was made?
can probably have the same blockquote, which can pretty much bee your comment from this PR? Maybe add in a link to the Encoding https://developer.apple.com/documentation/swift/string/encoding/nonlossyascii They've both been in there since 8.0, which means I just didn't realize this was the right default to continue using \n characters :( and then finally in IOS17 they ninja fixed like you said.
|
|
Hey sure. I have added some docs. I hope this is what you were after. Happy to make any changes. |
|
Legit enough for me, any other issues are future Ken's problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In iOS17 and seemly silent change has occurred where utf encoded strings with newline characters are correctly encoded. This means that the default delimiter of a new line character does not get picked up in the read function and so no message is returned.
This PR changed the default encoding to
nonLossyASCII