Fix/agp support android (#331)

* AGP support react-native-community/discussions-and-proposals#671 * remove package value react-native-community/discussions-and-proposals#671
kenjdavidson · Jul 22, 2024 · 9df8b81 · 9df8b81
1 parent ff01d76
commit 9df8b81
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/android/build.gradle b/android/build.gradle
@@ -16,6 +16,13 @@ def getExtOrDefault(name, fallback) {
 }
 
 android {
+    // Check AGP version for backward compatibility w/react-native versions still on gradle plugin 6
+    // it looks like this causes issues between 7 and 8, so for the time being 
+    def agpVersion = com.android.Version.ANDROID_GRADLE_PLUGIN_VERSION    
+    if (agpVersion.tokenize('.')[0].toInteger() >= 7) {
+        namespace = "kjd.reactnative.bluetooth"
+    }
+
     compileSdkVersion getExtOrDefault('compileSdkVersion', 34)
     buildToolsVersion getExtOrDefault('buildToolsVersion', "34.0.0")
 

diff --git a/android/src/main/AndroidManifest.xml b/android/src/main/AndroidManifest.xml
@@ -1,8 +1,7 @@
 
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-          package="kjd.reactnative.bluetooth">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
     <uses-permission android:name="android.permission.BLUETOOTH" />
     <uses-permission android:name="android.permission.BLUETOOTH_ADMIN" />
     <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
 </manifest>
-
+