Add ability to add handlers for raised exceptions #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syeopite
commented
Aug 21, 2024
src/kemal/exception_handler.cr
Outdated
| @@ -11,12 +11,26 @@ module Kemal | |||
| rescue ex : Kemal::Exceptions::CustomException | |||
| call_exception_with_status_code(context, ex, context.response.status_code) | |||
| rescue ex : Exception | |||
| # Use error handler defined for the current exception if it exists | |||
| return call_exception_with_exception(context, ex, 500) if Kemal.config.error_handlers.has_key?(ex.class) | |||
There was a problem hiding this comment.
This line is added above the log function in order for the specs to pass.
A logger is needed for #log to be able to successfully run which the tests in exception_handler_spec.cr doesn't appear to have defined.
This shouldn't be a problem in the real world case as a logger would always exist afaik.
Please let me know if this should be rectified in some other way.
|
This is perfect! |
Sija
suggested changes
Sep 15, 2024
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
syeopite
force-pushed
the
handle-custom-errors
branch
from
e7f441a to
bf19e27
Compare
`ex.class <= key` below should already handle the exact match ```crystal Kemal.config.error_handlers.each_key do |key| if ex.class <= key end end ```
Prior to this commit, handlers for exceptions and handlers for HTTP status codes were stored in a single collection. However, the two are used completely independently from each other and should instead be stored in two separate collections.
Sija
reviewed
Dec 18, 2024
sdogruyol
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
LGTM @syeopite, thanks a lot 👍 Waiting for the review of @straight-shoota ⌛
straight-shoota
approved these changes
Dec 19, 2024
sdogruyol
approved these changes
Dec 19, 2024
syeopite
added a commit
to syeopite/invidious
that referenced
this pull request
Dec 19, 2024
Kilt is unmaintained and the ECR templating logic has been natively integrated into Kemal with the issues previously seen having been resolved. This commit is mostly a precursor to support the next Kemal release which will add the ability to create error handlers for raised exceptions. See kemalcr/kemal#688
syeopite
added a commit
to syeopite/invidious
that referenced
this pull request
Dec 19, 2024
Kilt is unmaintained and the ECR templating logic has been natively integrated into Kemal with the issues previously seen having been resolved. This commit is mostly a precursor to support the next Kemal release which will add the ability to create error handlers for raised exceptions. See kemalcr/kemal#688
syeopite
added a commit
to syeopite/invidious
that referenced
this pull request
Jan 29, 2025
Kilt is unmaintained and the ECR templating logic has been natively integrated into Kemal with the issues previously seen having been resolved. This commit is mostly a precursor to support the next Kemal release which will add the ability to create error handlers for raised exceptions. See kemalcr/kemal#688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #622
Description of the Change
This PR adds the ability for users to define error handlers that are used when a specific exception is raised.
Alternate Designs
Benefits
This provides for a cleaner and easier experience for defining custom errors. See #622.
Possible Drawbacks