Including openssl.lib for Windows building

[seanmonstar]

This takes the work from @weareu, and creates a binding.gyp, and the openssl.lib file you get from building nodejs.

They provide the node.lib file from the their dist, but not openssl, so I just added it to deps. I could be absolutely crazy, but building this at least made the bcrypt build finally.

for issue #77

[travisbot]

This pull request fails (merged 5acfc15 into d96e100).

[defunctzombie]

This doesn't pass tests. Also the commits would need to be cleaned up a lot (I believe we already have gyp support so adding it again is not needed). This cannot be merged as is.

[seanmonstar]

It passes tests on Windows, so this must have fudged with how it's built in
Linux.

The commits were just starting from the other Windows work. I can rewrite
it into a single commit if need be, I mainly wanted to see if there were
any objections with including openssl.lib in the deps folder.

On Monday, July 16, 2012, Roman Shtylman wrote:

This doesn't pass tests. Also the commits would need to be cleaned up a
lot (I believe we already have gyp support so adding it again is not
needed). This cannot be merged as is.

---

Reply to this email directly or view it on GitHub:
#91 (comment)

Sean McArthur
http://seanmonstar.com

[defunctzombie]

This is totally a no go. From what I can tell that is a precompiled binary file. Honestly, windows users need to figure out how to install openssl or reference the node version, we will not be shipping our own copy.

[seanmonstar]

Yea, I thought it was a bit crazy, but wasn't sure, since node distributes a precompiled binary at http://nodejs.org/dist/v0.8.2/x64/

The OpenSSL site suggests grabbing the library for Windows at http://slproweb.com/products/Win32OpenSSL.html. Perhaps The Way would be to require Windows users download that, install it in the default location, and then we can use that. I have this option working locally as well, if it sounds reasonable.

[ncb000gt]

GH-92