Refactor test to use jest #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Quadriphobs1 I'm planning to merge in #440. But, I really like the changes that you've both made. Would you be willing to rebase master and make these changes again? I'd ultimately like for you both to get the #hacktoberfest credit since you both put in effort on the task. Thanks! Edit: I haven't merged 440 yet. I just merged a couple other open prs. |
|
Ok. I've merged the other PR. I'll land yours as soon as the conflicts are resolved. Thanks again! |
|
Conflicts has been updated now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the test to make use of jest and all of its flavours.
What I did
After finishing with this I realised it has been done at #440 however, I realised the changes made in the PR actually replaced syntax but not taking into consideration other aspects of the test so I decided to create the PR afterwards.
Closes #439