Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] 0.5.0b - Multiple scan errors #42

Closed
supernova-ws opened this issue Dec 18, 2023 · 2 comments
Closed

[bug] 0.5.0b - Multiple scan errors #42

supernova-ws opened this issue Dec 18, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@supernova-ws
Copy link

For some reasons correct values logged as "illegal value". Most interesting that all 3 reported relics are 3-star rarity. May be there is some issue in validation table?

[10:54:01] > WARNING: Relic ID 1453: Substat CRIT DMG_ has illegal value "3.4".
[10:54:03] > WARNING: Relic ID 1448: Substat CRIT DMG_ has illegal value "3.4".
[10:54:04] > WARNING: Relic ID 1447: Substat CRIT Rate_ has illegal value "3.4".
[10:54:04] > WARNING: Relic ID 1447: Substat Break Effect_ has illegal value "3.4".
{
    "relics": [
        {
            "set": "Genius of Brilliant Stars",
            "slot": "Feet",
            "rarity": 3,
            "level": 0,
            "mainstat": "SPD",
            "substats": [
                {
                    "key": "CRIT DMG_",
                    "value": 3.4
                }
            ],
            "location": "",
            "lock": true,
            "_id": "relic_1453"
        },
        {
            "set": "Messenger Traversing Hackerspace",
            "slot": "Feet",
            "rarity": 3,
            "level": 9,
            "mainstat": "SPD",
            "substats": [
                {
                    "key": "ATK",
                    "value": 11
                },
                {
                    "key": "DEF_",
                    "value": 3.2
                },
                {
                    "key": "CRIT DMG_",
                    "value": 3.4
                },
                {
                    "key": "Effect Hit Rate_",
                    "value": 2.5
                }
            ],
            "location": "",
            "lock": true,
            "_id": "relic_1448"
        },
        {
            "set": "Hunter of Glacial Forest",
            "slot": "Body",
            "rarity": 3,
            "level": 9,
            "mainstat": "CRIT DMG",
            "substats": [
                {
                    "key": "ATK",
                    "value": 12
                },
                {
                    "key": "DEF",
                    "value": 12
                },
                {
                    "key": "CRIT Rate_",
                    "value": 3.4
                },
                {
                    "key": "Break Effect_",
                    "value": 3.4
                }
            ],
            "location": "Yanqing",
            "lock": true,
            "_id": "relic_1447"
        }
    ]
}

1453
image

1448
image

1447
image

@kel-z
Copy link
Owner

kel-z commented Dec 19, 2023

Updated substat lookup tables in latest release.

@supernova-ws
Copy link
Author

Works fine in 0.5.1b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants