Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Baozimh.org and rename to GoDa Manhua #3087

Merged
merged 11 commits into from
May 30, 2024

Conversation

choppeh
Copy link
Contributor

@choppeh choppeh commented May 17, 2024

Closes #826

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

@AwkwardPeak7 AwkwardPeak7 requested a review from stevenyomi May 19, 2024 10:32
@stevenyomi
Copy link
Contributor

I'll tweak this in 2 or 3 days.

@stevenyomi stevenyomi marked this pull request as draft May 19, 2024 14:53
@choppeh choppeh closed this May 24, 2024
@choppeh choppeh deleted the bugfix/zh/baozimhorg branch May 24, 2024 01:15
@choppeh choppeh restored the bugfix/zh/baozimhorg branch May 24, 2024 01:21
@choppeh choppeh reopened this May 24, 2024
* Update code
* Rename source to GoDa Manhua and update icon (to distinguish from the "legit" Baozi Manhua)
* Add English source
@stevenyomi stevenyomi changed the title Fix Baozimh Fix Baozimh.org and rename to GoDa Manhua May 29, 2024
@stevenyomi stevenyomi marked this pull request as ready for review May 29, 2024 20:29
@stevenyomi
Copy link
Contributor

There's an English source (also an aggregator) which I added in the source factory, but it's not included for now because the package is still zh.baozimhorg. Chinese users don't use Discord so they don't receive status updates, so it's better not to change the package name for now.

Technically, putting a source factory in zh will work correctly now that the source list is flattened. Let me know if you think putting a zh+en extension (where Chinese users are major) under zh. package prefix is acceptable :)

@stevenyomi stevenyomi linked an issue May 29, 2024 that may be closed by this pull request
5 tasks
@stevenyomi stevenyomi merged commit 70592b2 into keiyoushi:main May 30, 2024
22 checks passed
@NeKoOuO

This comment was marked as resolved.

@hsiayuchih
Copy link

cool! Finally fixed, been waiting for this for a long time...

@choppeh choppeh deleted the bugfix/zh/baozimhorg branch May 31, 2024 13:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chinese source(GoDa漫畫) baozimh.org
5 participants