Skip to content

Soul Scans (ID): Update code to new web structure and update lib#17892

Open
MuhamadSyabitHidayattulloh wants to merge 7 commits into
keiyoushi:mainfrom
MuhamadSyabitHidayattulloh:jules-1493235589808717810-194bb3b0
Open

Soul Scans (ID): Update code to new web structure and update lib#17892
MuhamadSyabitHidayattulloh wants to merge 7 commits into
keiyoushi:mainfrom
MuhamadSyabitHidayattulloh:jules-1493235589808717810-194bb3b0

Conversation

@MuhamadSyabitHidayattulloh

@MuhamadSyabitHidayattulloh MuhamadSyabitHidayattulloh commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Closes #17592
Checklist:

  • Updated versionCode value in build.gradle.kts
  • Updated baseVersionCode in build.gradle.kts (if updated multisrc theme code)
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Set the contentWarning configuration in build.gradle.kts appropriately
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension
  • This PR is AI-assisted, I have reviewed the changes manually and confirmed they are not slop

@MuhamadSyabitHidayattulloh
MuhamadSyabitHidayattulloh marked this pull request as ready for review July 24, 2026 10:47

// ============================== CONFIGURATION ==============================

override val supportsLatest = true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true by default


override fun OkHttpClient.Builder.configureClient(): OkHttpClient.Builder = rateLimit(2)

override fun Headers.Builder.configureHeaders(): Headers.Builder = add("Referer", "$baseUrl/")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

referer is there by default in KeiSource

// ============================== PAGES ==============================

override suspend fun getPageList(chapter: SChapter): List<Page> {
val (mangaSlug, chapterSlug) = parseChapterUrl(chapter.url)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider saving mangaSlug in memo

class GenreFilter :
UriPartFilter(
"Genre",
arrayOf("All" to "") + arrayOf(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider fetching genre list if possible

ReadingFilter(),
GenreFilter(),
Filter.Separator(),
Filter.Header("Semua filter di atas maupun di bawah bisa dikombinasikan termasuk pencarian teks."),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Filter.Header("Semua filter di atas maupun di bawah bisa dikombinasikan termasuk pencarian teks."),
Filter.Header("Semua filter bisa dikombinasikan dengan pencarian teks."),

maybe ¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Soul Scans : URL Change request

3 participants