FoolSlide multisrc: extlib 1.6#17884
Open
furaibo9714 wants to merge 2 commits into
Open
Conversation
AwkwardPeak7
requested changes
Jul 24, 2026
AwkwardPeak7
requested changes
Jul 26, 2026
| fetchChapters: Boolean, | ||
| ): SMangaUpdate { | ||
| val request = allowAdult(GET(baseUrl + manga.url, headers)) | ||
| val document = client.newCall(request).await().asJsoup() |
Contributor
There was a problem hiding this comment.
Suggested change
| val document = client.newCall(request).await().asJsoup() | |
| val document = client.newCall(request).awaitSuccess().asJsoup() |
| fetchDetails: Boolean, | ||
| fetchChapters: Boolean, | ||
| ): SMangaUpdate { | ||
| val request = allowAdult(GET(baseUrl + manga.url, headers)) |
Contributor
There was a problem hiding this comment.
consider making an interceptor instead
| ?.use { response -> pageListParse(response).firstOrNull()?.imageUrl } | ||
|
|
||
| override fun mangaDetailsParse(response: Response): SManga = mangaDetailsParse(response.asJsoup()) | ||
| ?.let { url -> client.newCall(allowAdult(GET(url, headers))).execute() } |
Contributor
There was a problem hiding this comment.
avoid blocking network calls, make methods suspend and use client.get equivilent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
versionCodevalue inbuild.gradle.ktsbaseVersionCodeinbuild.gradle.kts(if updated multisrc theme code)contentWarningconfiguration inbuild.gradle.ktsappropriatelyidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extension