add informer client code to instance manager generated by codegen #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #448 +/- ##
==========================================
- Coverage 50.38% 50.36% -0.02%
==========================================
Files 33 34 +1
Lines 5216 5218 +2
==========================================
Hits 2628 2628
- Misses 2439 2441 +2
Partials 149 149 ☔ View full report in Codecov by Sentry. |
yuxuanzhu0214
force-pushed
the
informer-client
branch
from
6901c2b
to
a62ef0b
Compare
…eikoproj#442) Signed-off-by: Yuxuan Zhu <yuxuan_zhu@intuit.com>
Signed-off-by: Yuxuan Zhu <yuxuan_zhu@intuit.com>
Signed-off-by: Yuxuan Zhu <yuxuan_zhu@intuit.com>
Signed-off-by: Yuxuan Zhu <yuxuan_zhu@intuit.com>
…rate Signed-off-by: Yuxuan Zhu <yuxuan_zhu@intuit.com>
Signed-off-by: Yuxuan Zhu <yuxuan_zhu@intuit.com>
yuxuanzhu0214
force-pushed
the
informer-client
branch
from
f76b8a3
to
faee516
Compare
| @@ -1,7 +1,7 @@ | |||
| package controllers | |||
|
|
|||
| import ( | |||
| v1alpha "github.com/keikoproj/instance-manager/api/v1alpha1" | |||
| v1alpha "github.com/keikoproj/instance-manager/api/instancemgr/v1alpha1" | |||
There was a problem hiding this comment.
why change the directory structure?
There was a problem hiding this comment.
because we are using the open source code generator to generate the clientset/informer, and they are expecting the apis should have the following directory structure:
api(s)/$group/$version
shreyas-badiger
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added informer client code using codegen so component can import client informer code from instance manager.
fixes: #445