avoid potential NULL pointer deref

keepkey · Jul 7, 2021 · 7263d78 · 7263d78
1 parent 0527170
commit 7263d78
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/firmware/crypto.c b/lib/firmware/crypto.c
@@ -268,9 +268,12 @@ int cryptoMessageVerify(const CoinType *coin, const uint8_t *message,
 
 uint8_t *cryptoHDNodePathToPubkey(const CoinType *coin,
                                   const HDNodePathType *hdnodepath) {
-  if (!hdnodepath->node.has_public_key ||
-      hdnodepath->node.public_key.size != 33)
+  if (!hdnodepath ||
+      !hdnodepath->node.has_public_key ||
+      hdnodepath->node.public_key.size != 33) {
     return 0;
+  }
+
   static HDNode node;
   if (hdnode_from_xpub(hdnodepath->node.depth, hdnodepath->node.child_num,
                        hdnodepath->node.chain_code.bytes,