Skip to content

feat: Add clickable link to URL in Alert side panel #5159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2025

Conversation

chafouin
Copy link
Contributor

@chafouin chafouin commented Jul 9, 2025

Closes #5158

πŸ“‘ Description

Add a URL field in the Alert side panel with a clickable link if the URL is set for that alert.

image

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Copy link

vercel bot commented Jul 9, 2025

@chafouin is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2025

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Feature A new feature UI User interface related issues labels Jul 9, 2025
@shahargl
Copy link
Member

Hey @chafouin - can you sign the CLA?

Copy link

vercel bot commented Jul 10, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
keep βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 15, 2025 7:02am

talboren
talboren previously approved these changes Jul 10, 2025
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@talboren talboren enabled auto-merge (squash) July 10, 2025 06:41
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 10, 2025
@shahargl
Copy link
Member

@chafouin the frontend build fails -
CleanShot 2025-07-14 at 10 37 53

can you maybe fix?

@shahargl shahargl requested review from talboren and shahargl July 14, 2025 07:38
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Jul 14, 2025
auto-merge was automatically disabled July 14, 2025 21:38

Head branch was pushed to by a user without write access

Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 30.73%. Comparing base (0026346) to head (b4c7863).
Report is 25 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5159       +/-   ##
===========================================
- Coverage   46.18%   30.73%   -15.46%     
===========================================
  Files         173      101       -72     
  Lines       17970    11493     -6477     
===========================================
- Hits         8299     3532     -4767     
+ Misses       9671     7961     -1710     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shahargl shahargl merged commit 4004d61 into keephq:main Jul 15, 2025
16 of 17 checks passed
Copy link
Contributor

πŸš‚ Fantastic work @chafouin! Your very first PR to keep has been merged! πŸŽ‰πŸ₯³

You've just taken your first step into open-source, and we couldn't be happier to have you onboard. πŸ™Œ
If you're feeling adventurous, why not dive into another issue and keep contributing? The community would love to see more from you! πŸš€

For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. UI User interface related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[βž• Feature]: Add clickable link to URL in Alert side panel
5 participants