Skip to content

feat(api): add index on alert table#2377

Merged
shahargl merged 2 commits intomainfrom
feature/index-alert-hash
Nov 3, 2024
Merged

feat(api): add index on alert table#2377
shahargl merged 2 commits intomainfrom
feature/index-alert-hash

Conversation

@shahargl
Copy link
Copy Markdown
Member

@shahargl shahargl commented Nov 3, 2024

close #2376

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 3, 2024
@vercel
Copy link
Copy Markdown

vercel bot commented Nov 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2024 9:25am

@dosubot dosubot bot added the API API related issues label Nov 3, 2024
Copy link
Copy Markdown
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 3, 2024
@shahargl shahargl merged commit 88ef44b into main Nov 3, 2024
@shahargl shahargl deleted the feature/index-alert-hash branch November 3, 2024 09:27
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.32%. Comparing base (7d90ae9) to head (e026233).
Report is 75 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2377       +/-   ##
===========================================
- Coverage   71.20%   31.32%   -39.89%     
===========================================
  Files         154       63       -91     
  Lines       14046     6871     -7175     
===========================================
- Hits        10002     2152     -7850     
- Misses       4044     4719      +675     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API API related issues lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[➕ Feature]: add indexing on (tenant_id, fingerprint, timestamp)

2 participants