Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: /incident/{incident-id}/alerts now return only alerts with unique fingerprints #2235

Conversation

VladimirFilonov
Copy link
Contributor

@VladimirFilonov VladimirFilonov commented Oct 18, 2024

Closes #2218

📑 Description

Best to deliver together with #2217

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 10:55am

@VladimirFilonov VladimirFilonov force-pushed the fix/2218-bug-endpoint-incidentindient-idalerts-should-return-only-alerts-with-unique-fingerprints branch from 3672510 to 822fc03 Compare October 18, 2024 08:44
@Matvey-Kuk Matvey-Kuk force-pushed the fix/2218-bug-endpoint-incidentindient-idalerts-should-return-only-alerts-with-unique-fingerprints branch from 822fc03 to 819659b Compare October 18, 2024 09:31
@VladimirFilonov VladimirFilonov force-pushed the fix/2218-bug-endpoint-incidentindient-idalerts-should-return-only-alerts-with-unique-fingerprints branch from 819659b to ce997f0 Compare October 18, 2024 12:21
@Matvey-Kuk Matvey-Kuk self-requested a review October 21, 2024 07:13
…ts-should-return-only-alerts-with-unique-fingerprints
…ts-should-return-only-alerts-with-unique-fingerprints

Signed-off-by: Tal <tal@keephq.dev>
…ts-should-return-only-alerts-with-unique-fingerprints
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 28, 2024
…ts-should-return-only-alerts-with-unique-fingerprints
Copy link
Contributor

@Matvey-Kuk Matvey-Kuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agree with Shahar, more comments will be helpful

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 29, 2024
…ts-should-return-only-alerts-with-unique-fingerprints
Copy link

gitguardian bot commented Oct 29, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8134198 Triggered Generic High Entropy Secret 15ab526 keep-ui/app/frigade-provider.tsx View secret
14332896 Triggered Generic Password 46f8fda keep/providers/graylog_provider/docker-compose.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

…ts-should-return-only-alerts-with-unique-fingerprints
…ts-should-return-only-alerts-with-unique-fingerprints
@VladimirFilonov VladimirFilonov merged commit 0adc920 into main Oct 31, 2024
11 checks passed
@VladimirFilonov VladimirFilonov deleted the fix/2218-bug-endpoint-incidentindient-idalerts-should-return-only-alerts-with-unique-fingerprints branch October 31, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Endpoint /incident/{incident-id}/alerts should return only alerts with unique fingerprints
4 participants