Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AES-256/GCM fixes #8968

Merged
merged 7 commits into from
Jan 29, 2023
Merged

Commits on Jan 7, 2023

  1. Fix detecting AES-256/GCM cipher

    When you generate a ssh key using the aes-256/gcm cipher, the cipher
    name in the keyfile includes an @openssh.com at the end.
    
    Switch to checking if the cipher starts with aes256-gcm instead of
    checking for an exact match to account for this.
    novasharper committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    f6f48d9 View commit details
    Browse the repository at this point in the history
  2. Use separate iv length for getting iv data

    The iv length is different from the block size for GCM
    novasharper committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    1ad75cd View commit details
    Browse the repository at this point in the history
  3. Disable AES-256/GCM for now

    Currently, the granularity for the botan gcm implementation is too large.
    To fix a problem with another algorithm in the library, they are multiplying
    the blocksize, so by default the granularity is 64. This causes issues since
    the encrypted data in the key is only guaranteed to have a length that is a
    multiple of the block size (16).
    novasharper committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    f919484 View commit details
    Browse the repository at this point in the history
  4. Update translations

    novasharper committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    68491d6 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Configuration menu
    Copy the full SHA
    622f7a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8f014ee View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Configuration menu
    Copy the full SHA
    0033ee2 View commit details
    Browse the repository at this point in the history