Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #147. Although KeePassHTTP is still a weak protocol and its main flaws remain, this implementation should be safe enough for releasing it as part of KeePassXC.
Description
KeePassXC strictly limits communication to the local loopback interface at 127.0.0.1. This address is hardcoded and cannot be changed. The plugin is now also disabled by default at runtime and needs to be explicitly enabled before KeePassXC listens to any requests from PassIFox or chromeIPass.
Additional changes in this PR:
How Has This Been Tested?
There are still no unit tests for the HTTP plugin, but all functionality was tested manually.
The patch was tested both on my Arch system as well as in an Ubuntu 16.04 virtual machine.
Types of changes
Checklist: