feat: Add {CLIENT_HOSTNAME} placeholder support for backup file patterns #12701
+17
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Author
|
Should I have been notified of these build failures? Based on the output, they seem unrelated to my changes:
and
Am I missing something, do I need to make changes? Thanks! |
This commit introduces a new placeholder `{CLIENT_HOSTNAME}` that can be used in database backup file patterns. The hostname of the client performing the database save operation will be substituted in place of this placeholder.
Changes include:
- Documentation update to reference the new `{CLIENT_HOSTNAME}` placeholder in the Reference.adoc file
- Implementation of hostname resolution using `QHostInfo::localHostName()` in Tools.cpp
- Addition of Qt5::Network library dependency for both the autotype library and testtools unit test
- New test cases to verify proper substitution of the `{CLIENT_HOSTNAME}` placeholder
- Test case for escaped patterns to ensure they are not replaced
- Updated existing test data to include CLIENT_HOSTNAME in multiple pattern replacement test
The feature enhances backup file naming flexibility by allowing users to include the client hostname in their backup file names, which is particularly useful in multi-machine environments.
ryan-steed-usa
force-pushed
the
client_hostname_db_backup_placeholder
branch
from
44efb31 to
9af7c14
Compare
Member
|
Disregard those failures we had an issue with our CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request introduces a new placeholder
{CLIENT_HOSTNAME}that can be used in database backup file patterns. The hostname of the client performing the database save operation will be substituted in place of this placeholder.Changes include:
{CLIENT_HOSTNAME}placeholder in the Reference.adoc fileQHostInfo::localHostName()in Tools.cpp{CLIENT_HOSTNAME}placeholderThe feature enhances backup file naming flexibility by allowing users to include the client hostname in their backup file names, which is particularly useful in multi-machine environments.
Note: Generative AI was used only to summarize the commit log.
Screenshots
Testing strategy
Type of change