Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adjusting application font size #11567

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

droidmonkey
Copy link
Member

@droidmonkey droidmonkey commented Dec 16, 2024

  • Closes Allow selecting font size  #6822
  • Fix fixed font not following default font's point size
  • Allow for custom offset values manually set in the config file (bounded to -2 to 4)

Screenshots

image

Small Font:
image

Large Font:
image

Testing strategy

Tested on Windows, may need testing on other platforms

Type of change

  • ✅ New feature (change that adds functionality)

* Closes #6822
* Fix fixed font not following default font's point size
@droidmonkey droidmonkey added user interface pr: new feature Pull request that adds a new feature labels Dec 16, 2024
@droidmonkey droidmonkey added this to the v2.7.10 milestone Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.92%. Comparing base (f2ed4e3) to head (864908b).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/gui/ApplicationSettingsWidget.cpp 78.57% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11567      +/-   ##
===========================================
+ Coverage    63.88%   63.92%   +0.04%     
===========================================
  Files          362      362              
  Lines        38147    38171      +24     
===========================================
+ Hits         24370    24399      +29     
+ Misses       13777    13772       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xboxones1
Copy link
Contributor

I checked in Linux, it works fine. Is more fine tuning possible? I would like to set the font size in numbers instead of four presets.

@droidmonkey
Copy link
Member Author

The presets are: -1, 0, +1, +2 points offset from baseline. If you want to go down to -2 or +3 or +4, then you csv do that manually in the ini file. You really can't get more variety than that.

@NickWick13
Copy link

How about adding tiny and huge options?

@droidmonkey
Copy link
Member Author

I tested this with tiny (-2) and huge (+4) during development. Tiny makes text unreadable. Huge breaks the UI. The choices presented are purposefully made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new feature Pull request that adds a new feature user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow selecting font size
3 participants