Fix setting window title as modified

[varjolintu]

When creating a new entry to database, the window title does not include an asterisk character. When going to Settings / Password generator, the title appears correctly.

Fixes #11540

Testing strategy

Manually. Switching tab to a closed database, or Settings / Password generator removes the asterisk character from the title.

Type of change

• ✅ Bug fix (non-breaking change that fixes an issue)

[varjolintu]

Noticed that this fix works, but Qt gives a warning to the console: QWidget::setWindowModified: The window title does not contain a '[*]' placeholder. If we want to get rid of that warning too, another solution must be found.

Even if MainWindow::updateWindowTitle() has isModified set to false, in some cases the title will still include the asterisk character.

[droidmonkey]

https://doc.qt.io/qt-5/qwidget.html#windowModified-prop

The window title must contain a "[]" placeholder, which indicates where the '' should appear. Normally, it should appear right after the file name (e.g., "document1.txt[*] - Text Editor"). If the window isn't modified, the placeholder is simply removed.

The placeholder should be in the window title no matter what.

[varjolintu]

I made a simple fix for this where the title is set to the placeholder first, and then to the actual one. It was the only way I could find to go around this (I'm pretty sure it's some kind of Qt bug). Also tried the title setter as a signal/slot (tried both: settings modified and/or setting the title), but that didn't solve the issue either.

[droidmonkey]

Is this ready to go?

[varjolintu]

Is this ready to go?

Yes. If everything works for you as well.