The password generator doesn't remember configuration

[iSylleo]

Overview

Unchecking special characters (like /*+&) only takes effect currently. KeePassXC doesn't remember the previously configured unchecking special characters.

Steps to Reproduce

1. Open the password generator:

2. Uncheck the special characters:

3. Close the generator and reopen it again:

Now the generator checks the special characters again, which does not remember my configuration. This behavior seems to be happened internally, but it also influences the password generator of KeePassXC-Browser plugin, I cannot get a expected password.

Expected Behavior

KeePassXC should remember the configuration and write it into the config file, and apply it immediately.

Actual Behavior

The previously unchecked special characters appears again when I reopen the generator, the configuration only takes effect currently.

Context

Related issue: #5525
This problem appears since version 2.6.1, but has not been fixed yet.
The temporary solution is change this configuration in the config file, but it is not a good way.

I install KeePassXC using scoop: scoop install keepassxc

KeePassXC - Version 2.6.2
Revision: e9b9582

Qt 5.15.1
Debugging mode is disabled.

Operating system: Windows 10 Version 2004
CPU architecture: x86_64
Kernel: winnt 10.0.19041

Enabled extensions:

• Auto-Type
• Browser Integration
• SSH Agent
• KeeShare (signed and unsigned sharing)
• YubiKey

Cryptographic libraries:
libgcrypt 1.8.6

Operating System: Windows 10 2004

[droidmonkey]

I fixed this in #5129

[droidmonkey]

Ugh confirmed, this is broken

[droidmonkey]

I typoed here:

keepassxc/src/gui/PasswordGeneratorWidget.cpp

Lines 176 to 180 in cd519e1

	if (m_ui->buttonAdvancedMode->isChecked()) {
	config()->set(Config::PasswordGenerator_SpecialChars, m_ui->checkBoxSpecialChars->isChecked());
	} else {
	config()->set(Config::PasswordGenerator_Logograms, m_ui->checkBoxSpecialChars->isChecked());
	}

There should be a "!" in the if statement.