"Delete Entry…" suggests confirmation dialog but doesn't show one

[ermshiperete]

The menu items for deleting an entry show an ellipses ("Delete Entry…") which by convention means that a confirmation dialog is shown. However, if the "Move entries to recycle bin without confirmation" option is enabled no dialog is shown. This can be unexpected and confusing to the user if he isn't aware of the state of that option.

It would be good if the ellipses would be omitted if that option is enabled.

[droidmonkey]

Even better, we should change the text to "Move to Recycle Bin" or similar if the recycle bin is enabled. If you have an entry selected in the bin, it would then show the Delete Entry text.

[BohdanQQ]

Hi, how about this?

The only questions I have are related to translations (the reason I haven't submitted a PR):

1. I only added strings for US and GB translations. How do I handle other languages? Do I add an "incomplete" translation for each language by hand, use a tool I have missed, or... ?

2. Is the way I copied "Delete Entry(s)…" translation into the MainWindow context "correct" way to do this? (otherwise only "Delete Entry(s)…" is displayed)

[droidmonkey]

Don't do any translation work. If you add (s) to your string then also include a number variable in the tr(...) call to select single or multiple translations.

[BohdanQQ]

Which is what I did. The problem was that the tr call did not translate Delete Entry(s)… at all. It started translating it after I copied the translation (in a .ts file) into the "MainWindow" context.
As for the "Move Entry(s) to Recylce Bin" string - I had to add this one since it simply didn't exist.