Reword the default alert message to match the app's scope - #205
Merged
Conversation
The old default ("Hello! ... Please send help!") read as personally
typed, implied a confirmed emergency, and gave the recipient no
concrete first action. Per the framing in #193: an "Automated alert:"
opener makes the trigger explicit, the uncertainty stays ("may need
assistance"), and the action is graduated and location-neutral - try
to make contact, then check on the person.
Wordings are compacted from the issue's suggestions because the
alert-message dialog rejects text over 160 characters and the default
is prefilled when adding the first contact. Each locale keeps the
register of its existing translation; German follows the issue
author's du-form suggestion; zh-CN gets a real translation (it was
untranslated English). Existing contacts are unaffected - each contact
stores its own message copy, so this only changes the default for
newly added contacts.
Fixes #193
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the reframing from #193. The old default ("Hello! ... Please send help!") read as personally typed, implied a confirmed emergency, and gave the recipient no concrete first action.
New English default (143 chars):
Following the issue's reasoning: "Automated alert:" makes the trigger explicit, "may need assistance" keeps the uncertainty, and the action is graduated and location-neutral (contact first, then a welfare check), leaving escalation to the recipient's judgement.
Notes on the details:
SMS_MESSAGE_MAX_LENGTH) and the default is prefilled when adding the first contact, so the suggested EN (~166) and DE (~210) wordings would have shipped a default the Save button rejects. All eight versions are 143-158 chars.default_alert_message_alt(used only by screenshot tests) is untouched.LocaleStringParityTestand resource compilation pass.Fixes #193