Show a warning state when monitoring has no alert recipient - #201
Merged
Conversation
The main screen showed the green Monitoring Active status whenever monitoring was enabled with a scheduled alarm, recent activity, and permissions - it never checked whether any alert could actually be delivered. With no enabled SMS contact, no call contact, and no webhook, monitoring ran as a silent no-op behind a reassuring green status; the only cue was the greyed-out test button. Monitoring enabled with no usable alert channel is now its own warning-colored state with an explicit message. Enabling monitoring is still allowed so contacts can be set up afterwards. Fixes #187 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main screen showed the green "Monitoring Active" status whenever monitoring was enabled with a scheduled alarm, recent activity, and permissions - it never checked whether any alert could actually be delivered. With no enabled SMS contact, no call contact, and no webhook, monitoring ran as a silent no-op behind a reassuring green status; the only cue was the greyed-out test button.
"Monitoring enabled but no usable alert channel" is now its own warning-colored state ("No Alert Recipient") with an explicit message. The check mirrors the alert pipeline: an enabled SMS contact with a number, a call contact, or (in webhook builds) an enabled+configured webhook. Enabling monitoring is still allowed so contacts can be set up afterwards.
New
hasActiveAlertChannel()helper with unit tests; new strings translated for all 7 locales.Fixes #187
Generated with Claude Code