Check SEND_SMS permission from the background alarm cycle - #200
Merged
Conversation
A permission revoked after setup (battery sweep, OS update, someone adjusting settings) was previously only detected when the app was next opened, leaving a set-and-forget install silently unable to send SMS alerts. The periodic AlarmReceiver now verifies SEND_SMS is still granted whenever an enabled SMS contact is configured and posts a notification if it was revoked, rate-limited to once per day. The check never blocks the alert check itself. Fixes #192 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A permission revoked after setup (battery sweep, OS update, someone adjusting settings) was previously only detected when the app was next opened - for a set-and-forget app that leaves the install silently unable to send SMS alerts until it is too late.
The periodic AlarmReceiver now verifies SEND_SMS is still granted whenever an enabled SMS contact is configured, and posts a notification (tap opens the app) if it was revoked. Rate-limited to once per day; the marker clears when the permission is restored so a future revocation notifies immediately. The check never blocks the alert check itself, and the first pass is deliberately scoped to SEND_SMS per the issue discussion.
New strings translated for all 7 locales; covered by new AlarmReceiverTest cases.
Fixes #192
Generated with Claude Code