Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add contract verification to release pipeline addressing #246

Conversation

bruhhgnik
Copy link
Contributor

Addressing #240

Pull Request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Currently, there is no verification that the ECIP contract is declared on networks before package release.

Issue Number: #240

What is the new behavior?

  • Added contract verification to release pipeline for both PyPI and NPM packages
  • Verifies ECIP contract is declared on Sepolia and mainnnet before allowing release
  • Verification only runs during release (tag push)

Does this introduce a breaking change?

  • Yes
  • No

Other information

Contract verification is added to both:

  • maturin.yml (PyPI release)
  • wasm.yml (NPM release)

Copy link
Collaborator

@feltroidprime feltroidprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a .py script and run it from CI instead of having duplicate code.

@bruhhgnik
Copy link
Contributor Author

Create a .py script and run it from CI instead of having duplicate code.

I made the above said changes, kindly check

@feltroidprime
Copy link
Collaborator

feltroidprime commented Oct 28, 2024

Simply format the script using black to make CI pass.

@bruhhgnik
Copy link
Contributor Author

bruhhgnik commented Oct 28, 2024

Simply format the script using black to make CI pass.

could you kindly check if its alright now?
i have ran pre-commit run -a

and it reformatted .github\scripts\verify_contract.py

@feltroidprime feltroidprime merged commit c45a52b into keep-starknet-strange:main Oct 28, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants