Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust implementation of Cairo Poseidon transcript #171

Merged
merged 7 commits into from
Aug 23, 2024
Merged

Rust implementation of Cairo Poseidon transcript #171

merged 7 commits into from
Aug 23, 2024

Conversation

raugfer
Copy link
Collaborator

@raugfer raugfer commented Aug 22, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Cairo Poseidon transcript is implemented in Python

Issue Number: #160

What is the new behavior?

Implemented in Rust using FieldElement

Does this introduce a breaking change?

  • Yes
  • No

@raugfer raugfer marked this pull request as ready for review August 22, 2024 20:23
@raugfer raugfer requested a review from feltroidprime as a code owner August 22, 2024 20:23
feltroidprime
feltroidprime requested changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@feltroidprime feltroidprime left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Just create a constant for Felt252 : 2^96.
Same thing can be done with BigUint masks as well.

tools/garaga_rs/src/poseidon_transcript.rs Outdated Show resolved Hide resolved
@feltroidprime feltroidprime merged commit aed2291 into keep-starknet-strange:main Aug 23, 2024
22 checks passed
@raugfer raugfer deleted the rust-poseidon-transcript branch August 23, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feltroidprime feltroidprime feltroidprime requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raugfer @feltroidprime